Changeset: 63071623
http://www.openstreetmap.org/way/209645380 fixing a link to Wikipedia. In wikipedia/wikidata tags only entries about given feature should be linked. See https://wiki.openstreetmap.org/wiki/Key:wikipedia
Closed by Mateusz Konieczny
Tags
armchair_justification | this edit relies on general knowledge ( like "Żabka (convenience store)" Wikipedia page is not describing single convenience store but chain/brand of convenience store") and is not making changes that require local survey for verification |
---|---|
armchair_justification_opposite | for example adding brand tags based solely on name tag would be in my opinion example of wrong, revertable and harmful armchair editing - knowledge whatever shop named "Żabka" is part of Żabka convenience shop chain requires local knowledge |
automatic | no, it is a manually reviewed edit |
cases_where_human_help_is_required | https://matkoniecz.github.io/OSM-wikipedia-tag-validator-reports/ |
created_by | osmapi/1.0.2 |
source | general knowlege, checking link target |
source_code | https://github.com/matkoniecz/OSM-wikipedia-tag-validator.git |
Discussion
-
Comment from ndm
Will be reverted - brand:wikipedia is not in the wiki.openstreetmap.org. Links in osmand, etc. will fail.
-
Comment from Mateusz Konieczny
Hopefully revert rate will be not higher than with other tagging for renderer.
Good point about OSM website, I added "autolinking brand:wikipedia and other *:wikipedia tags on OSM website" to my (already way too long) TODO list.
-
Comment from ndm
It breaks all existing tools -- will ask DWG to take a look -- if it just added something like wikipedia:link = brand, then fine it's just "noise", those that care read it, those that don't can continue as usual.
-
Comment from SomeoneElse
I'd have thought that brand:wikipedia=en:IKEA was the correct tagging here, as that wikipedia entry isn't for this individual store but for the whole chain? The website (which points at the store locator page for this store) is of course OK.
-
Comment from Mateusz Konieczny
Note that this type of linking is not new - see https://wiki.openstreetmap.org/wiki/Key:wikipedia#Secondary_Wikipedia_links
wikipedia, wikidata tags should used only if wikipedia article or wikidata entry is about this feature
For example famous tree may have its own wikipedia article. Trees that have no own articles will not have wikipedia links.
For example wikipedia=en:Oak is wrong in the same way as wikipedia=en:Ikea
-
Comment from Mateusz Konieczny
"It breaks all existing tools" - incorrect tagging to satisfy some tools is not accepted in OSM - see https://wiki.openstreetmap.org/wiki/Tagging_for_the_renderer
Note also that false wikipedia/wikidata links break tools that expect that wikipedia tag to be used correctly.
-
Comment from ndm
Still not sure what Żabka has to do with IKEA -- but good to see that there is a hint about "brand:wikipedia" in the wiki now :-)
Perhaps linking to the discussion on the imports list would be better in terms of a justification -- and more informative.
-
Comment from Mateusz Konieczny
"now" - it is there since a quite long time.
"linking to the discussion on the imports list" - given that it is not an import (or even an automatic edit) I am unfortunately unable to provide such link.
-
Comment from ndm
Maybe this would be good to add:
https://lists.openstreetmap.org/pipermail/talk/2017-September/thread.html#78902
-
Comment from Mateusz Konieczny
Is there anything useful in that discussion? I try to ignore "Yuri Astrakhan vs mailing list" threads.
Ways (1)
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |