Changeset: 44075647
Add iso 31662 codes
Closed by thailand-edits
Tags
created_by | JOSM/1.5 (10786 en) |
---|---|
source | Bing |
Discussion
-
Comment from stephankn
this is clearly a mechanical edit. I do not see any documented prior discussion. Please give some details, as I am not convinced that replacing addr:* with is_in:* is the current standard.
-
Comment from thailand-edits
This wasn't a mechanical edit but a mass JOSM edit based on towns which contained addr:* tags.
I agree this was a large changeset, however each case was properly inspected.
Could you point out which nodes were mistagged? If you find a lot of them we can always revert this changeset, however to my understanding towns shouldn't have addr:* tags.
Most of these edits replaced addr:country=TH => is_in:country_code=TH
If you are not convinced with the current standard, I was looking at the Town OSM Wiki page and it doesn't mention anything with addr:* (might be outdated and needs an update).
-
Comment from stephankn
Thanks for responding to the comment.
Doing a mass change of tags is considered a mechanical edit. Whether you are using JOSM or other tools is not relevant in this context.
It seems this change was not discussed with the community. Or was it somewhere?
I see the problem that some details had not been migrated when you changed the tagging.
For example here:
https://www.openstreetmap.org/node/1684727085/historyyou have removed other details, eg:
addr:district หนองสองห้องSo you could argue that this can be derived from the admin polygones. But same is true for the is_in structure you had added.
Would be great if you could respond in the forum: https://forum.openstreetmap.org/viewtopic.php?id=60482
Opinions are mixed, so certainly something which should be discussed. There is also the option to first revert and then to re-apply the change and this time preventing the loss of details. Or maybe only reverting it partially based on criteria we can define. -
Comment from thailand-edits
I agree, this changeset is a bit large for a mass edit, but it was discussed and posted on the OSM mailing list, I can't find the exact thread but I've got a response from Miroff which was one of the users who added the addr:* in the first place.
https://github.com/osmottawa/osm-changesets/issues/3
@Stephan, feel free to revert and update or simply revert this changeset. But it would be nice to have some consistency on the addr:* tags which don't belong on place=town nodes.
-
Comment from stephankn
I recommend to move the discussion to the forum thread mentioned above. That way we can document the decision better.
Might be an interesting decision whether to go for addr:*. is_in:* or completely remove those where admin boundaries are available.
I am not too keen on investing time to do a proper revert of something which also took you time to do.
I am personally undecided whether is_in is better or worse than addr tags in this situation. I always considered them only being a mid-term solution on the way to admin boundaries.
The thing to worry about is that some details are lost due to the tag change.
So please let's bring all those details to the forum.
-
Comment from Johnny Carlsen
I just noticed that "is_in:state" does not contain the local language. Shouldn't "is_in:state" be in Thai?
-
Comment from Johnny Carlsen
I was just looking at this changeset again and I can see a lot of valuable information were removed by it.
Before:
addr:continent Asia
addr:country TH
addr:district เมืองอุดรธานี
addr:district:en Mueang Udon Thani
addr:hamlet หมู่ที่ 3
addr:province อุดรธานี
addr:province:en Udon Thani
addr:subdistrict บ้านจั่น
addr:subdistrict:en Ban Chan
name บ้านคำกลิ้ง
name:en Ban Kham Kling
place village
source Bing; signAfter:
is_in:continent Asia
is_in:country Thailand
is_in:country_code TH
is_in:iso_3166_2 TH-41
is_in:state Udon Thani
is_in:state_code 41
name บ้านคำกลิ้ง
name:en Ban Kham Kling
place village
source Bing; signWhy remove this much data? Even if mistagged, that was still really useful information.
- บ้านโนนโพธิ์ไทร (1541921663), v2
- บ้านโนนโพธิ์ (1771390961), v3
- บ้านโนนโพธิ์ (1531023711), v2
- บ้านโนนโพธิ์ (1350940532), v2
- บ้านโนนพริก (1767024157), v2
- บ้านโนนภูทอง (1671047783), v2
- บ้านโนนปอแดง (1671047715), v2
- บ้านโนนประวิดี (1885248831), v2
- บ้านโนนราศรี (1610184629), v2
- บ้านโนนราศรี (1344465454), v2
- บ้านโนนแร่ (1240508460), v3
- บ้านโนนรัง (1685855561), v2
- บ้านโนนรัง (1773381690), v2
- บ้านโนนรัง (520863272), v12
- บ้านโนนรัง (1481101537), v2
- บ้านโนนรัง (1481101540), v2
- บ้านโนนรัง (1534928897), v2
- บ้านโนนรัง (1534928900), v2
- บ้านโนนรัง (1897669006), v2
- บ้านโนนราษี (1238253591), v2
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |