Changeset: 46516476
Fix opening_hours typo and syntax errors
Closed by parukhin
Tags
created_by | JOSM/1.5 (11526 ru) |
---|
Discussion
-
Comment from GRUBERND
looking through some of those edits: how come "Winter" should equal "Dec-Feb" and "Summer" was changed to "Jun-Aug"?
both assumptions do not reflect reality.
so.. why the change? -
Comment from Spiegel0
I've also picked only some changes and had a closer look at them. Without knowing the actual opening hours, most of them seem to be useful improvements. Unfortunately, the changeset is huge and looks quite overwhelming. Hence, I probably cannot review all changes systematically. As GRUBERND said, there are some substantial errors regarding seasons. Take node 3594330289 or 420462131, for example. Both nodes used to contain data which is, afaik, not defined in the Wiki but these changes definitely introduce some further errors. On most other nodes I've reviewed, the changes just seem to eliminate German terms and abbreviations but "summer" does not directly translate to "Jun-Aug".
Were these changes automatically generated? -
Comment from parukhin
Yes, "Winter" to "Dec-Feb" and "Summer" to "Jun-Aug" is a semiautomatic JOSM correction. What is it "Summer" and "Winter" in Germany? I find this examle in German wiki "Winterzeit 8-18, Sommerzeit: 7-20: Mar Su[-1] - Oct Su[-1]-1 days: 07:00-20:00; Oct Su[-1] - Mar Su[-1]-1 days: 08:00-18:00"
https://wiki.openstreetmap.org/wiki/DE:Key:opening_hours This is correct?
Now i'm revert these changes back to "Summer" and "Winter". -
Comment from GRUBERND
thank you very much! the problem with the values "winter" and "summer" is that they have a seasonal meaning. for example some amenity=drinking_water will be shut down some time between September/October until March/April. but the dates are not really clear.
in some cases (toilets in skiing areas) the "winter" just means "as long as the skiing area is in active use.so reverting those values would be very helpful - for precision and also to not hide this problem in the opening_hours scheme.
-
Comment from MKnight
winter and summer should not (auto)corrected without more knowledge about. Josm is mostly wrong in this case.
winter (and summer) has (min) 2 meanings:
dec-feb (winter) or winter time= End of Oct to end of Mar.parukhin: please reverse the changes in Germany and other too. For example in #45944320 there are 15 winter/summer-changes of you.
-
Comment from MKnight
reverted in #46516476
- 478035923, v1
- Rotes Kreuz Purkersdorf (26299582), v11
- Orth-Haslau (26556675), v7
- Schlager (28333389), v9
- Wirtschaftskammer und WIFI Oberösterreich - Bezirksstelle Schärding (30541582), v11
- Spar (34943618), v8
- X-Cube (41215475), v7
- Möderndorfer Mostheuriger (45260778), v4
- Irish Pub (46110333), v3
- ehemaliger Zielpunkt (46964357), v6
- Donauturm (46965660), v15
- Veľvyslanectvo Talianska (58372651), v10
- Archäologischer Park Carnuntum (62019490), v15
- OBRA Kinderland (65710732), v13
- Seecamping Gruber (78147726), v5
- Gasthaus zur Blutalm (81533147), v12
- Zum Kirchenwirt (82748434), v9
- Quester Baustoffhandel GmbH (84087368), v4
- Hofpürglhütte (84131551), v6
- Unimarkt (85519031), v5
Relations (5)
- Bus 131: Hlavná stanica => Cintorín Slávičie údolie (1792806), v29
- Dr. med. dent. Christina Fürst (3489250), v2
- Dr. med. dent. Ulrich Fürst (3489251), v2
- SPAR Markt Dorn Postpartner (5332747), v3
- Restaurant Laguna (5460322), v3
- Philipp (31625408), v11
- Apotheke Liebenau (31797495), v17
- BAWAG PSK (46823957), v14
- Hotel Stich (60217106), v9
- Amerlingbeisl (244497161), v8
- Gasthof zum lustigen Bauern (250694477), v6
- Cafe Mitte (251711053), v9
- Gasthof Knöbl (253225303), v11
- Spar (277415713), v13
- Avanti (286039605), v5
- Gasthof Zum Bayernbrunnen (287632812), v4
- Himmel und Wasser (294285276), v6
- Zum schwarzen Adler (306942254), v6
- Geflügel Draxler (316419529), v9
- The Golden Harp (323672015), v10
- 123tanken.at (327305679), v4
- Regenbogenapotheke "Am Leberberg" (331063936), v8
- Optimus Garage BC 20 (333123597), v12
- Kaffee Konditorei Monarchie (333539957), v5
- 2544 Leobersdorf (340518819), v11
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |