Changeset: 51350214
per wikipedia tag in wiki, moving wp & wd to operator:wp & wd, see wikipedia tag, and https://wiki.openstreetmap.org/wiki/Wikidata_RDF_database#Quality_Control_Queries for general QA queries
Closed by nyuriks
Tags
created_by | JOSM/1.5 (12545 en) |
---|
Discussion
-
Comment from SafwatHalaby
Hello, thank you for taking your time and editing the map. I have some questions.
Wiki states: "You *may* tag secondary attributes of the feature by preceding the wikipedia key with the name of the attribute". This is clearly optional, and I chose to avoid it for simplicity because the individual shops are extremely unlikely have their own wiki pages, and because the plain form is likely more widely supported.
2. Was this mechanical edit discussed anywhere prior to the edit, as required in the automated edits code of conduct[1]? Firstly, these nodes have no "operator" tags as agreed upon in the IL forums[3], but the edit adds an "operator:wd/wp". It would have been more accurate to add a "brand:wd/wp". Also, these tags are mechanically maintained by SwiftFast_bot[2], which is now throwing warnings. Prior discussion would have been nice.
lastly, the link in the description seems broken. There's no section for quality control.
Thank you for your time.
[1] https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct
[2] https://wiki.openstreetmap.org/wiki/User:SwiftFast/scripts/brand
[3] https://forum.openstreetmap.org/viewtopic.php?pid=645276 -
Comment from SafwatHalaby
I apologize, the forum thread relevant for brand vs operator is actually https://forum.openstreetmap.org/viewtopic.php?id=57986
-
Comment from nyuriks
@SwiftFast, thanks for the thorough message! I will be happy to fix those objects, and I agree that it should have been brand, not operator, as was suggested to me via another channel. Also, thanks for the great forum discussion. I hope we can move forward on some proposals to standardize wd/wp tag usage.
I have been actively adding "wikidata" tags to those entries that already have "wikipedia" tags, which allowed community to perform a lot of cleanups, like fixing incorrect or stale wikipedia tags. I also built a service similar to Overpass that contains combined data from both the OSM and Wikidata databases. This allowed very sophisticated data quality control. Those QA queries are now in the "examples" page, accessible either from wiki or directly from the tool's "examples" button. Moreover, I am very hopeful that your bots can use this service directly, and help with cleaning up and maintain objects everywhere.
Once I tagged substantial number of wikipedia-only objects with wikidata, I started analyzing them all to find places of business that were clearly in large numbers - in other words, those whose wikidata represented a chain rather than a specific place. I believe that I have made a mistake with that edit - they should have been tagged as brands, not operators. My understanding was initially based on how many operator:wp/wd tags there are. I already started reversing this after some conversations, but perhaps a wider discussion should take place before the global cleanup.
I hope we can standardize on wp/wd tags being a 1:1 representation of the object, not its brand/operator/artist/subject/... This will allow a more precise info.
* QA queries https://wiki.openstreetmap.org/wiki/SPARQL_examples
* https://wiki.openstreetmap.org/wiki/Proposed_features/Wikidata
* related, with good discussion on talk page: https://wiki.openstreetmap.org/wiki/Proposed_features/Wikipedia_tag_types
* New page (WIP) - https://wiki.openstreetmap.org/wiki/Wikidata_Classification_Guide -
Comment from nyuriks
P.S. A few days ago I started a list of all Wikidata IDs that should always be used as brand:wikidata. Should we have this as a github repo for some script? https://wiki.openstreetmap.org/wiki/Wikidata%2BOSM_SPARQL_query_service#Current_Challenges
-
Comment from SafwatHalaby
Specifically for israel: There's no need for an ID table or manually reversing your edits. Swiftfast_Bot maintains those chains, and all you have to do is edit the following templates.
Here are the templates: https://wiki.openstreetmap.org/wiki/User:SwiftFast/scripts/brand/templates
So you'd need to add:
- brand:wikidata = whatever's the right value
- brand:wikipedia = whatever's the right valueand remove "wikipedia", "wikidata".
The bot will then fix all chains. (And I can easily tell it to remove wikipedia/operator:wikipedia/ etc).
-
Comment from SafwatHalaby
" I believe that I have made a mistake with that edit - they should have been tagged as brands, not operators." - Note that this actually depends on the regional conventions (if they exist at all). In Israel, chains have the same "brand" but this is not necessarily true everywhere. And prior to Swiftfast_Bot there was no consistency at all. (some people used the operator tag and some used brand).
-
Comment from nyuriks
This is awesome!!! I think we should adapt your bot to other places, e.g. US and Russia (the two places I know a bit better than others). Could you make your bot also track any entries that have the same wikidata ID as ones listed in the template, and update those places accordingly?
-
Comment from SafwatHalaby
Thanks! I also think this should be adopted globally, but I still need to polish/simplify the code a bit first. The bot makes assumptions that are agreed upon only in Israel and there's special treatment for some tags like name/operator. Making it global requires a bit more work.
Most people don't add the Wikidata tag, so right now the bot tracks many tags like brand/name/operator to track POIs. I could make it track using the wikidata tag if it's present and fall back to other tags otherwise.
- Comment from SafwatHalaby
Ways (1-20 of 25)
- 1
- 2
- פז (190109295), v6
- דלק (191475312), v5
- פז (191475322), v6
- פז (193591064), v6
- סונול (193591083), v6
- דלק (193995865), v5
- דלק (194003787), v5
- סונול (194895162), v6
- פז (194895262), v6
- סונול (198521481), v5
- סונול (219179381), v6
- דלק (221000335), v5
- דלק (238587178), v6
- דלק (256757942), v5
- דלק (294384445), v6
- סונול (294617189), v5
- סונול (295006915), v6
- דלק (295008270), v4
- סונול (295188455), v5
- סונול (295333340), v5
- דלק (71082606), v11
- פז (71083832), v11
- סונול (93808095), v13
- פז (249237534), v13
- פז (267236087), v10
- פז (269460378), v14
- דלק (269460528), v12
- דלק (270291020), v9
- סונול (270292964), v11
- פז (288685159), v10
- פז (306344407), v10
- דלק (330232401), v8
- פז (331345094), v10
- דלק (331345539), v8
- סונול (331345603), v9
- סונול (331351696), v10
- סונול (331352898), v10
- פז (331353277), v9
- פז (335842866), v9
- דלק (335850954), v7
Welcome to OpenStreetMap!
OpenStreetMap is a map of the world, created by people like you and free to use under an open license.
Hosting is supported by Fastly, OSMF corporate members, and other partners.
https://openstreetmap.org/copyright | https://openstreetmap.org |
Copyright OpenStreetMap and contributors, under an open license |